Support uploads to draft releases#117
Draft
zeitlinger wants to merge 2 commits intotaiki-e:mainfrom
Draft
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Owner
|
Could you tell me what the actual problem you're trying to solve is? As said in #110, this isn't necessary with tag-based triggers or manual tag specification. Also, since release-based triggers aren't triggered by draft releases, the workflow won't run in the first place. |
Author
I'll try to dig into this more - to be able to have a reproducer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support uploading assets to existing draft releases.
Why
release-plzand similar immutable-release workflows create the GitHub release as a draft first, then upload assets, then publish the release after the matrix succeeds.The action currently finishes with
gh release upload <tag>, which looks up the release by tag and can fail for draft releases.What changed
gh release uploadstep with draft-aware upload logictag_namefrom the releases APIupload_urland upload assets directlyrefValidation
bash -n main.shshellcheck main.sh